Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-engine-wasm): quick and dirty SQLite-only Wasm QE #4606

Closed
wants to merge 1 commit into from

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Dec 22, 2023

DO NOT MERGE

Gzip'd size: 1067496 B.

Copy link
Contributor

WASM Size

Engine This PR Base branch Diff
WASM 2.719MiB 2.866MiB -150.233KiB
WASM (gzip) 1.019MiB 1.055MiB -36.102KiB

Copy link

codspeed-hq bot commented Dec 22, 2023

CodSpeed Performance Report

Merging #4606 will not alter performance

Comparing tmp/sqlite-only-wasm (5d218b4) with main (dbb3fbf)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

✅ WASM query-engine: no benchmarks have regressed

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs

After changes in 5d218b4

@jkomyno jkomyno self-assigned this Jan 3, 2024
@jkomyno
Copy link
Contributor Author

jkomyno commented Jan 11, 2024

We're not going to merge this as it is, but this idea could still be worth to implement.

@jkomyno jkomyno closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant